Add importer for spectra from NERC FSF instruments

robintw / Py6S

A Python interface to the 6S Radiative Transfer Model

GNU Lesser General Public License v3.0

191 stars 105 forks source link

Add importer for spectra from NERC FSF instruments #25

Closed danclewley closed 8 years ago

danclewley commented 8 years ago

Add importers for spectra collected using field spectrometers to Py6S.SixSHelpers.spectra. Specifically make importer for .sig format files, developed by @arsf for internal use, available within Py6S.

For more details on the format see FSF import guide (pdf)

(Opening issue as a reminder I had discussed with @robintw doing this. If anyone wants the reader before a pull request is submitted to Py6S let me know).

robintw commented 8 years ago

Thanks @danclewley.

I've been wondering about creating a separate module (PySpectra?) to contain functions for reading spectra from various files. This would enable them to be used from Py6S, but also from any other modules without requiring Py6S to be installed. What do you think?

The file formats that could be included in the module, are currently:

USGS Spectral Library (in Py6S)
ASTER Spectral Library (in Py6S)
ENVI Plot Window ASCII export files (I have code to do this elsewhere)
ENVI Spectral Library (I think I have code to do this elsewhere)
DART Spectra files (I have code to do this elsewhere)
OceanOptics SpectraSuite files (I have code to do this elsewhere)
.sig format files (as you mention above)

Any thoughts?

danclewley commented 8 years ago

Having a separate module to read in spectra in different formats, so they can be passed to Py6S, is a great idea. This is actually what we were going for internally and the .sig reader is part of this. The general design is there is a single function to read spectra (which you pass in the filename and type) then there are separate classes in which readers for each format are implemented.

Instead of us making the .sig reader fit into Py6S would it be better if I create a separate repo containing our initial implementation of PySpectra (can't think of a better name!) and after we've figured the design out you add your importers to this?

robintw commented 8 years ago

Sounds perfect - thanks!

robintw commented 8 years ago

(Also, just while I remember to tell you, you may be interested in another module I've released: PyMicrotops - see https://github.com/robintw/PyMicrotops)

danclewley commented 8 years ago

I've set up a repository with our existing code: https://github.com/pmlrsg/PySpectra for additional importers to be added to. Any comments on design welcome (suggest opening an issue for discussion).

Marking as closed.