Currently, when accidentally using 6S-V2.1 instead of the legacy V1.1 version, Py6S does not give an error but gives wrong values instead.
As the output of 6S-V2.1 is very similar to the output of V1.1, Py6S apparently does not fail to parse the file. However, the newer output has 2 extra lines in the upper part of the ouput, as can be seen in this diff between an output of 6S-V2.1 and V1.1 when run on the same input file:
Note that most of the differences are irrelevant, and just due to small floating point differences. However, these 2 lines are present in the V2.1 output and are lacking in the V1.1 output, just after the 'ground altitude' line:
I suppose Py6S does not check which version of 6S was used, and just parses certain lines from the output file. In case of V2.1, it will therefore parse the wrong values when these lines are past the 2 extra lines.
Proposed solution:
check the version of 6S in the first line of the output file. If not 1.1, give an error instead of giving wrong values.
I'll file another issue to discsuss V2.1 support, which might or might not be as simple as just skipping these extra 2 lines when parsing the output file.
Currently, when accidentally using 6S-V2.1 instead of the legacy V1.1 version, Py6S does not give an error but gives wrong values instead.
As the output of 6S-V2.1 is very similar to the output of V1.1, Py6S apparently does not fail to parse the file. However, the newer output has 2 extra lines in the upper part of the ouput, as can be seen in this diff between an output of 6S-V2.1 and V1.1 when run on the same input file:
Note that most of the differences are irrelevant, and just due to small floating point differences. However, these 2 lines are present in the V2.1 output and are lacking in the V1.1 output, just after the 'ground altitude' line:
I suppose Py6S does not check which version of 6S was used, and just parses certain lines from the output file. In case of V2.1, it will therefore parse the wrong values when these lines are past the 2 extra lines.
Proposed solution: check the version of 6S in the first line of the output file. If not 1.1, give an error instead of giving wrong values.
I'll file another issue to discsuss V2.1 support, which might or might not be as simple as just skipping these extra 2 lines when parsing the output file.