search

robintw / Py6S

A Python interface to the 6S Radiative Transfer Model
GNU Lesser General Public License v3.0
191 stars 105 forks source link

S2A & S2B relative spectral response function #39

Closed MarcYin closed 4 years ago

MarcYin commented 6 years ago

This updates Sentinel-2A spectral responses and changes are mainly modifying the responses for bands B01 and B02, which is important for the aerosol retrieval. The sentinel 2B relative spectral response functions are also added.

robintw commented 6 years ago

Thanks for submitting this PR.

In general, I'm happy to accept it - but I'm wondering why you have changed the names of the spectral response functions? Eg. S2A_SR_AV_B01 rather than S2A_MSI_01?

MarcYin commented 6 years ago

That's the name specified in the official spectral response function file and it's averaged values of measured spectral responses for each band of the Sentinel-2 MultiSpectral Instrument (MSI) for the different satellite units, which explains why it has _AV_ in each band. But if you want still use the original names, we can roll back to previous names.

robintw commented 6 years ago

Ah yeah, I see where they come from.

I think the original names would be better (for both S2A and S2B) - it'd save changing other bits of the code, or other people's code.

MarcYin commented 6 years ago

Ok, I have changed it and fixed the indexes overlaps between different sensors.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 79.648% when pulling 2d75954e6587b32ee8ef9c9a7279f1d3786ad82b on MarcYin:patch-4 into b96d776dc7219d5c2668fdf7c2fe5b5712dc30d7 on robintw:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 79.648% when pulling 2d75954e6587b32ee8ef9c9a7279f1d3786ad82b on MarcYin:patch-4 into b96d776dc7219d5c2668fdf7c2fe5b5712dc30d7 on robintw:master.

robintw commented 5 years ago

Is this fixed by #50?

MarcYin commented 5 years ago

Hi, this should have been fixed in #51