search

robintw / Py6S

A Python interface to the 6S Radiative Transfer Model
GNU Lesser General Public License v3.0
191 stars 105 forks source link

Add Sentinel-3B SLSTR spectral response functions and S3B helpers #53

Closed lwandrebeck closed 4 years ago

robintw commented 4 years ago

Hi, thanks for the PR.

The Continuous Integration tests aren't passing at the moment, and they're failing on the S3B_SLSTR_05 wavelength definition, and the error suggests it's because the wavelengths aren't at 2.5nm intervals.

If you could check that definition is correct and at 2.5nm intervals, then that'd be great.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.1%) to 82.6% when pulling 974a803483288cdf352d6c58957257159fcb571c on lwandrebeck:master into efe55783f4a37dc6ed04fc167509b1a987a28621 on robintw:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 82.664% when pulling d219f4cd46df54848055754cc8c8cd17e344d968 on lwandrebeck:master into efe55783f4a37dc6ed04fc167509b1a987a28621 on robintw:master.

lwandrebeck commented 4 years ago

Hi,

Just checked with the scientist who generated this, there was indeed an error, which should be fixed now.

lwandrebeck commented 4 years ago

Small fix for S3B_SLSTR_06 added.

lwandrebeck commented 4 years ago

Sorry for the noise, everything should be ok now.

robintw commented 4 years ago

Thanks - that's great. All tests pass, and I'll merge it now.

Thanks for your contribution!