search

robintw / Py6S

A Python interface to the 6S Radiative Transfer Model
GNU Lesser General Public License v3.0
186 stars 105 forks source link

Bugfix in 6s test #74

Closed simonrp84 closed 3 years ago

simonrp84 commented 3 years ago

Currently, the SixS.test function doesn't appear to properly use the path variable that is passed to it, in the case that the user supplies their own sixs executable.

This PR updates the _find_path function called in the test to enable the path variable to be passed correctly

codecov[bot] commented 3 years ago

Codecov Report

Merging #74 (3b94731) into master (8ef80cd) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files          17       17           
  Lines        1693     1693           
=======================================
  Hits         1413     1413           
  Misses        280      280
Impacted Files Coverage Δ
Py6S/sixs.py 63.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ef80cd...3b94731. Read the comment docs.

robintw commented 3 years ago

Thanks for the contribution - that's great :)