search

robinvanderknaap / MvcJqGrid

Fluent jqGrid Html Helper for ASP.NET MVC
www.playground.webpirates.nl/mvcjqgrid
GNU Lesser General Public License v3.0
101 stars 74 forks source link

formatoptions .ToLower() should be removed. #4

Closed planeterock closed 12 years ago

planeterock commented 12 years ago

Column.cs line 330, in the ToString() method, the ToLower on the format options is causing the baseLinkUrl not to work. it should be removed:

formatoptions: {" + _formatter.Value.Value + "}

aside from a few issues getting this up and running, (due to me missing js ref's or having them out of order, or not knowing i explicitly had to call .SetSortable, and these 2 bugs) this is a really awesome helper, and just what i was looking for! I will definately be using this wherever jqgrid is needed. Thanks!

daanl commented 12 years ago

planeterock could you create failing unit tests, so we can fix the bugs you mentioned.

And do an pull request of these.

robinvanderknaap commented 12 years ago

Added failing test and fixed the issue. Also added a link in readme.md to manual for installing jqgrid, hopefully this will make things more clear for first time users.

Nice to hear you like the helper!

planeterock commented 12 years ago

Sorry I couldn't get to this. I'm in the midst of changing jobs.

Sent from my iPad

On Jan 12, 2012, at 6:49 PM, Robin van der Knaap reply@reply.github.com wrote:

Added failing test and fixed the issue. Also added a link in readme.md to manual for installing jqgrid, hopefully this will make things more clear for first time users.

Nice to hear you like the helper!

Reply to this email directly or view it on GitHub: https://github.com/robinvanderknaap/MvcJqGrid/issues/4#issuecomment-3473363

robinvanderknaap commented 12 years ago

No problem, I'm glad you're reporting the issues.