search

robinvdvleuten / php-nntp

Client for communicating with servers throught the Network News Transfer Protocol (NNTP) protocol.
MIT License
39 stars 12 forks source link

Add POST command #18

Closed thebandit closed 8 years ago

thebandit commented 8 years ago

Allow posting of a message via the POST command.

I tried to keep it in line with the Pear lib's mail() method per some of your comments here although instinct is telling me to make the headers an array. If you agree I can amend the pull request.

robinvdvleuten commented 8 years ago

Hi @thebandit, thanks for your PR! It looks good to me, but it still needs some unit tests. Can you please add them?

thebandit commented 8 years ago

Hi, I'll see what I can do. Never done a unit test before so I need some time to figure out what's what.

robinvdvleuten commented 8 years ago

@thebandit no worries take your time! If you need some guidance let me know :)

thebandit commented 8 years ago

Hi, I've added some unit tests, hopefully they are sufficient.

robinvdvleuten commented 8 years ago

Awesome thanks @thebandit!