Closed WTDuck closed 4 years ago
vuex-persistedstate
node
npm
yarn
Relevant code or config
export default function ( options: Options | null, storage: Storage | null, // UNUSED and mandatory key: string | null // UNUSED and mandatory ) { options = options || {}; storage = options.storage || (window && window.localStorage); key = options.key || "vuex"; ... }
Problem: Since typescript implementations, storage and key parameters are now mandatory but not used in following assigned variables. Regular storage/key definition in options is still working
storage
key
options
Suggested solution:
export default function ( options?: Options | null, storage?: Storage | null, // UNUSED and mandatory key?: string | null // UNUSED and mandatory ) { options = options || {}; storage = options.storage || storage || (window && window.localStorage); key = options.key || key || "vuex"; ... }
Incoming PR for this code 😊
PR #258
Thanks! The PR is merged!
vuex-persistedstate
version: 3.0node
version: v13.11.0npm
(oryarn
) version: 6.14.4Relevant code or config
Problem: Since typescript implementations,
storage
andkey
parameters are now mandatory but not used in following assigned variables. Regular storage/key definition inoptions
is still workingSuggested solution:
Incoming PR for this code 😊