Closed teunbrand closed 4 years ago
I think the check failed because of some pdf/latex/vignette stuff. @robinweide are you ok with merging this anyway?
First of all, really nice work. It looks very tidy and I like the annotations. Seems like we now have two matrixplotters, which is not bad per se.
I think the check failed because of some pdf/latex/vignette stuff. @robinweide are you ok with merging this anyway?
No, we should fix it. The errors are all about this:
! Package pdftex.def Error: File `colour\T1\textunderscorehot.png' not found.
Let's try to find were you put underscores (or the colour "hot"). It would be ashame to have to ditch the travis-badge.
They are in man/figures/colour_hot.png
, which I used in ?GENOVA_colours
in colours.R. I made these so that the manual displays the colours, but I had to use markdown formatting for that doc to get these to work (which looks fine in the html docs). Perhaps we should revert to less fancy formatting and use branching logic instead, for example the one we use for the subscript '2' in log2: \ifelse{html}{\out{log<sub>2</sub>}}{\eqn{log_2}}
Pyramid plots now have an edge by default:
The edge follows cropping and is customisable:
There are also classic CTCF site annotations:
Compartment scores, insulation scores and directionality indices can be displayed as tracks by adding them to the plot.
You can exercise more precise control over them if you use
as_track()
on them:Domainograms and virtual 4Cs are added as seperate tracks:
You can add regular ggplot2 layers as long as some data value falls between the start and end of the pyramid plot:
Also, you can stack whatever annotations you want:
The disappearing y-axis on the compartment score is currently a bug.