Collapse the dual vs single into 1 function for insulation_matrix()
Maybe also allow dual compartment matrixplots?
A plotter for trans regions: trans_matrixplot(). We possible could generalise this to any off-diagonal region.
Streamlining
Redirect computation of compartment/insulation scores to the dedicated functions instead of doing them ad-hoc everytime something needs to be plotted. This way, we only need to maintain 1 body of code per score calculator.
In the same vein, we could add IS_discovery/CS_discovery arguments to these plotting function, to avoid recomputation. This could default to NULL in which case the score is computed de novo. This also ensures that the data you are plotting is the data you're using downstream (in e.g. TAD calling or Saddle computations).
teunbrand
commented
4 years ago
The
cis.compartment.plot()andplot_insulation_(single/dual)are due for an update.Naming
It would be neat to standardise the names of function that plot an hic-matrix with something added. E.g.:
cis.compartment.plot()-->compartment_matrixplot()plot_insulation_(single/dual)()-->insulation_matrixplot()hic.matrixplot()-->hic_matrixplot()New functionality
insulation_matrix()trans_matrixplot(). We possible could generalise this to any off-diagonal region.Streamlining
IS_discovery/CS_discoveryarguments to these plotting function, to avoid recomputation. This could default toNULLin which case the score is computed de novo. This also ensures that the data you are plotting is the data you're using downstream (in e.g. TAD calling or Saddle computations).