robinweide / GENOVA

GENome Organisation Visual Analytics
GNU General Public License v3.0
70 stars 15 forks source link

Balancing for mcool files while loading contacts? #361

Open MaybeBio opened 2 months ago

MaybeBio commented 2 months ago

Hi, I recently worked on multiple cool files between GENOVA and HiCExplorer. I first converted the matrix file from raw hic-pro format to cool file without Normalizing, Then i use HiCExplorer's hicNormalize and hicCorrectMatrix (--correctionMethod KR),

what i did using hicNormalize is this: image

image

then what i did using hicCorrectMatrix (--correctionMethod KR) is this: image

so i now have mcool files normalized using KR amongst multiple samples,what i confused is how do i set some of these parameters image 1,do i need to set scale_bp=NULL which was mentioned in #356, 2,do i need to set balancing=FALSE cause i see description " balancing | TRUE (default) will perform matrix balancing for .cooler and KR for.hic." but i have already done KR normalizing to mcool files ? Or are there any other Settings I need to be aware of

Thanks a lot, Best

sarahmnry commented 4 weeks ago

Hi,

I am having the same concern as I am loading my .mcool files that have already been normalized externally.

Because we are not using KR normalization for our data, I would like to import them with our custom normalization and I am wondering wether the balancing = FALSE will do that or load the raw data without the weight information?

If it loads the raw data, is there any option that would allow specifying the weight vector please?

Thanks a lot, Best,

Sarah Manoury-Battais

teunbrand commented 4 weeks ago

If balancing = TRUE, it will use the weight column in the .(m)cool file. If 'KR' is present, a weight column will be constructed from the inverse of 'KR". If you have a custom normalisation, make sure there is a 'weight' column and not a 'KR' column in order for balancing = TRUE to use the weight column.

sarahmnry commented 4 weeks ago

Thank you so much for your reactivity and for your help! When setting balancing=FALSE, I realized the matrix had decimal values, doesn't that mean that it already took the balanced data?

Thank you

teunbrand commented 4 weeks ago

It might just be the scale_bp setting that might make your integers into decimal values when balancing = FALSE.

sarahmnry commented 4 weeks ago

That makes sense, thank you! And congratulations for this tools, it's really nice to work with.

Best