search

robiot / xclicker

XClicker - Fast gui autoclicker for x11 linux desktops
https://xclicker.xyz
GNU General Public License v3.0
480 stars 42 forks source link

Fix crash when setting keybind #85

Closed robiot closed 1 year ago

robiot commented 1 year ago

Closes #83 possibly also closes #82, #68 I am not on a linux system rn so I cant test but I will try to remember to check when I can.

robiot commented 1 year ago

Yup this seems to have fixed the issue, at least for me. @UrsoTriangularo or @Shringe, could you test if it works on your machine, then I can merge and release?

Shringe commented 1 year ago

I can test later today and verify.

Shringe commented 1 year ago

@robiot how do I build the nightly with this commit? I have cloned the fix/g_idle_add_once branch and ran make release, but the following executable in ./build/release/src/xclicker still crashes when setting hotkey. I assume that was the stable branch and there is some way to build nightly with the commit in place, akin to some form of make nightly?

robiot commented 1 year ago

@Shringe Hmm very strange, make sure to clone, run git checkout fix/g_idle_add_once then make all. Let me know if that worked.

Shringe commented 1 year ago

Yep, make all was it not make release, seems to work completely fine now.

robiot commented 1 year ago

Ok perfect! Thanks for testing it out!