search

robisim74 / angular-l10n

Angular library to translate texts, dates and numbers
MIT License
380 stars 59 forks source link

Release a version with peerDependencies compatible with RxJS v7 #330

Closed coyoteecd closed 2 years ago

coyoteecd commented 2 years ago

Describe the bug Most recent versions of Angular 12 accept upgrading to RxJS v7. The peerDependencies entry in package.json of angular-l10n should account for this scenario.

At the moment, I see the following warning at npm install: npm WARN angular-l10n@12.0.0 requires a peer of rxjs@^6.5.4 but none is installed. You must install peer dependencies yourself.

robisim74 commented 2 years ago

Thanks for reporting. I will release a patch to fix it as soon as I have verified that the library is compatible with both version 6 and 7.

robisim74 commented 2 years ago

Just released a new version: https://github.com/robisim74/angular-l10n/releases

I had already removed the deprecated stuff in rxjs v6, and the library seems compatible. Any feedback is however appreciated.

coyoteecd commented 2 years ago

Updated both my projects with no visible issues. Thanks.