search

robisim74 / qwik-speak

Translate your Qwik apps into any language
https://robisim74.gitbook.io/qwik-speak/
MIT License
133 stars 15 forks source link

chore(plugin): Logging regarding missing values #109

Closed nelsonprsousa closed 9 months ago

nelsonprsousa commented 9 months ago

To avoid printing "Make sure the keys are in 'runtimeAssets': when there are no missing values.

Before:

client: root.tsx

Missing value for keys:

Make sure the keys are in 'runtimeAssets':

Qwik Speak Inline: build ends at 07/01/2024, 02:22:16

After: 

client: root.tsx

Missing value for keys:

No keys for 'runtimeAssets' necessary.

Qwik Speak Inline: build ends at 07/01/2024, 02:22:16
codesandbox[bot] commented 9 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

robisim74 commented 9 months ago

Hey @nelsonprsousa , thanks! But if you want to hide the warning for runtimeAssets you should apply it to these lines and dynamics array: https://github.com/robisim74/qwik-speak/blob/main/packages/qwik-speak/tools/inline/plugin.ts#L236-L237

Maybe we can hide both of them when they are empty, both missingValues and dynamics?

nelsonprsousa commented 9 months ago

Hey @nelsonprsousa , thanks! But if you want to hide the warning for runtimeAssets you should apply it to these lines and dynamics array: https://github.com/robisim74/qwik-speak/blob/main/packages/qwik-speak/tools/inline/plugin.ts#L236-L237

Maybe we can hide both of them when they are empty, both missingValues and dynamics?

That's true, my bad!

Gonna change the message for both arrays 👍