robisonsantos / evm

Erlang Version Manager
116 stars 27 forks source link

Support all erlang versions #33

Closed mritalian closed 4 years ago

mritalian commented 4 years ago

... not just those on the the download page, as there may be updates.

mritalian commented 4 years ago

For my purposes the evm script in its base form is useless. For example, 21.3 base is considerably outdated by 21.3.8.9; evm will always download the original one. This patch offers all possible versions. Also, in our docker images, we use very specific erlang versions and the dev environment must thus follow precisely.

Of course this patch breaks the naming convention of the versions compared to the base implementation. Versions are now of the form 21.3.8.5 and not OTP_21.3.

robisonsantos commented 4 years ago

Thanks for the PR. I'll check the change and incorporate them if there's no problem.

On Tue, Dec 10, 2019, 12:53 PM Eric B notifications@github.com wrote:

For my purposes the evm script in its base form is useless. For example, 21.3 base is considerably outdated by 21.3.8.9; evm will always download the original one. This patch offers all possible versions. Also, in our docker images, we use very specific erlang versions and the dev environment must thus follow precisely.

Of course this patch breaks the naming convention of the versions compared to the base implementation. Versions are now of the form 21.3.8.5 and not OTP_21.3.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/robisonsantos/evm/pull/33?email_source=notifications&email_token=AAA66LO5HYTAGAVAFSIEZQDQX76UPA5CNFSM4JZEUAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGQ5DYI#issuecomment-564253153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA66LOWUFV7CFMDCA4CRW3QX76UPANCNFSM4JZEUAJQ .

robisonsantos commented 4 years ago

I wasn't able to merge this PR as it is, but I incorporated the changes into the version 5.0.

Thanks for the changes.