robjohnnoble
commented
4 years ago Thanks, Cécile.
I’ve merged your changes to ggmuller.
I’ve been working on the plots for the forecasting paper, using your helpful documentation. The following relatively short file replaces most of the functionality of PlotsPaperForecasting.R: https://github.com/robjohnnoble/CecileCodeETH/blob/master/ForecastingPaper/RCleanCode_ForecastingPaper/RobPlotFunctions.R https://github.com/robjohnnoble/CecileCodeETH/blob/master/ForecastingPaper/RCleanCode_ForecastingPaper/RobPlotFunctions.R
I hope you had a good bike trip.
Rob.
On 8 Jun 2020, at 18:38, CecileLeSueur notifications@github.com wrote:
Hi Rob, I guess this is how you can get my modifications of ggmuller functions :) Let me know if not !
You can view, comment on, or merge this pull request online at:
https://github.com/robjohnnoble/ggmuller/pull/15 https://github.com/robjohnnoble/ggmuller/pull/15 Commit Summary
corrections to deal with some problems occuring when max(res$Generation) is achieved for 2 values of NumCells update of get_population_df such that it should be compatible with simulations with treatment update of get_population_df (cont.) File Changes
M R/SupplementaryFunctions.R https://github.com/robjohnnoble/ggmuller/pull/15/files#diff-63c2eb13dbbb5d4b3414e2b3ec073792 (37) Patch Links:
https://github.com/robjohnnoble/ggmuller/pull/15.patch https://github.com/robjohnnoble/ggmuller/pull/15.patch https://github.com/robjohnnoble/ggmuller/pull/15.diff https://github.com/robjohnnoble/ggmuller/pull/15.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/robjohnnoble/ggmuller/pull/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRYOHLP52LZTTWCLJTTUC3RVUHZ3ANCNFSM4NYSOJMQ.
Hi Rob, I guess this is how you can get my modifications of ggmuller functions :) Let me know if not !