search

robjohnnoble / ggmuller

Create Muller Plots of Evolutionary Dynamics
Other
64 stars 9 forks source link

Can't cope with multiple types appearing simultaneously #8

Closed robjohnnoble closed 6 years ago

robjohnnoble commented 6 years ago

The code expects only the common ancestor to have nonzero population at the first time point, and it expects subsequent types to switch from zero to nonzero population in sequence, one at a time. Otherwise get_muller_df throws an error (more specifically the error comes from add_start_points).

Proposed solution: if data violates the expectation then remedy the issue by adding time points.

robjohnnoble commented 6 years ago

Fixed by commit 2c236273bb1b0ecdac269ebfb4bd350cd62d0e25.