search

robjschroeder / App-Auto-Patch

Auto patch management script via Dialog
https://techitout.xyz/app-auto-patch/
MIT License
109 stars 18 forks source link

Bug when version checking DIsplay Link Manager & Ignoring DEPNotify #55

Closed Uggbert closed 6 months ago

Uggbert commented 6 months ago

From the logs:

App Auto-Patch: 2024-02-05 22:11:38 - [INFO] Found DisplayLink Manager.app version 1.10.0 App Auto-Patch: 2024-02-05 22:11:54 - [NOTICE] --- New version: 1.9 App Auto-Patch: 2024-02-05 22:11:54 - [NOTICE] Queueing displaylinkmanager

I think its maybe interpreting 1.10 as 1.0 ?

robjschroeder commented 6 months ago

Hey @Uggbert, it's not necessarily interpreting 1.10 as 1.0. It's looking to see if "$previousVersion" == "$appNewVersion". And we couldn't use a greater-than type of operator because how there are so many vendors out there that include letters or other types of things in their versioning strings. Weird though that the new version is 1.9 and you seem to have 1.10 installed, this looks like a problem with the Installomator label for displaylinkmanager

Uggbert commented 6 months ago

Ah ok I see, I can log an issue over at installomator or check the issues list there to see if it's a known issue, for now I will exclude it from the app auto patcher checks.

Thanks again, very slick implementation with minimal setup for me! Always a bonus, i'll be using this in production for sure once I do a bit more testing.

On Mon, 5 Feb 2024, 22:56 Robert Schroeder, @.***> wrote:

Hey @Uggbert https://github.com/Uggbert, it's not necessarily interpreting 1.10 as 1.0. It's looking to see if "$previousVersion" == "$appNewVersion". And we couldn't use a greater-than type of operator because how there are so many vendors out there that include letters or other types of things in their versioning strings. Weird though that the new version is 1.9 and you seem to have 1.10 installed, this looks like a problem with the Installomator label for displaylinkmanager

— Reply to this email directly, view it on GitHub https://github.com/robjschroeder/App-Auto-Patch/issues/55#issuecomment-1928453340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMF7CIBLYBIFWVSCJH2AD7DYSFPQ5AVCNFSM6AAAAABC256DRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYGQ2TGMZUGA . You are receiving this because you were mentioned.Message ID: @.***>

Uggbert commented 6 months ago

Update, its a known issue over at installomator: https://github.com/Installomator/Installomator/issues/1427

This can be closed.