robjschroeder / App-Auto-Patch

Auto patch management script via Dialog
https://techitout.xyz/app-auto-patch/
MIT License
109 stars 18 forks source link

Update the install/update window to AAP logo #66

Closed AndrewMBarnett closed 4 months ago

AndrewMBarnett commented 5 months ago

If the script can't find the app icon, it will default to the AAP logo after installing/updating.

AndrewMBarnett commented 5 months ago

Noticed I had copied an extra line in the PR. It should look like this below.

         if [[ ! -e "/Applications/${currentDisplayName}.app" ]]; then
            swiftDialogUpdate "listitem: index: $i, icon: $logoImage, status: wait, statustext: Checking …"
         else 
            swiftDialogUpdate "listitem: index: $i, icon: /Applications/${currentDisplayName}.app, status: wait, statustext: Checking …"
        fi
TechTrekkie commented 4 months ago

Hey @AndrewMBarnett ! I think we were going to stick with the currently implemented solution, which is currently we're populating the AAP Logo if the app icon can't be found, and then once the app is downloaded/patched the icon updates to the correct app icon. Below is an example of an app before and after its patched. Let me know if this works image image