search

robjuz / helm-charts

https://robjuz.github.io/helm-charts/index.yaml
34 stars 30 forks source link

allow providing the database DSN via extraEnv #29

Closed frank-bee closed 1 year ago

frank-bee commented 1 year ago

Allow providing the database DSN via extraEnv. Like this it could be provided as a k8s secret. I will provide a PR for that

robjuz commented 1 year ago

Why would you set the database DSN manually, external database is already supported.

If security of the database password is your consent, I can improve the external database values to accept a secret with credentials.

frank-bee commented 1 year ago

If security of the database password is your consent, I can improve the external database values to accept a secret with credentials.

Exactly, I wanted to add the whole database DSN via reference to a secret. More as a simple workaround

frank-bee commented 1 year ago

But if you plan to refactor this anyway: Ideally the password for the external DB could be referenced from a secret (optionally). There is also another problem with the password: if it contains e.g. special characters, that leads to problems in the URL. I had to use only numbers as a workaround.

robjuz commented 1 year ago

closing because of #48