search

robjuz / helm-charts

https://robjuz.github.io/helm-charts/index.yaml
34 stars 30 forks source link

Added support for secretReference to connect to external database #47

Closed dbt-lucka closed 1 year ago

dbt-lucka commented 1 year ago

Made it possible to reference an existing secret for specifying full DSN, as an alternative to the constructed DSN with cleartext password.

robjuz commented 1 year ago

Hi. Thx for the PR. It looks good. I just need to check if the database credentials are used somewhere else.

dbt-lucka commented 1 year ago

Cool. Just tested it on my GCP Cluster and it works. I forgot to document in values.yaml though. Will do so tomorrow.

dbt-lucka commented 1 year ago

Updated the documentation of values.yaml.

dbt-lucka commented 1 year ago

Nominatim is now up and running with the DSN injected as a secret 👍

Deployment: image

Secret: image

dbt-lucka commented 1 year ago

Creating a new PR that incorporates this feature and #38 as well.