search

robkinyon / dbm-deep

DBM::Deep Perl module
http://search.cpan.org/dist/DBM-Deep/
11 stars 16 forks source link

Use TODO tests for database transaction tests #17

Open jmaslak opened 8 years ago

jmaslak commented 8 years ago

This is a simple patch to remove the failures in the transaction error tests when SQLite or MySQL is used during testing. It marks the transaction error tests as TODO tests when the engine being tested is DBI. I didn't think making them pass or removing them was the right option because it is true that the database tests actually do fail because of missing functionality in the DBI module. Because that's called out in the POD, however, I also didn't think it should fail the test suite as a whole.

I received your module as a CPAN Pull Challenge for January, and will be submitting at least one more pull request dealing with the database back end (references are not always properly removed from the database when they are overwritten - I have the fix for this but need to write tests to validate). Please feel free to give me any feedback on this or any other pull requests I submit if I can/should submit them differently.

robkinyon commented 8 years ago

Please add yourself to the contributors and update the Changes file.

Thank you so much for taking the time to work on this module. I really appreciate it.