Make android includes compatible with firebase plugin.

roblav96 / nativescript-onesignal

A Nativescript plugin that wraps the iOS and Android OneSignal Push Notifications SDK.

https://documentation.onesignal.com/docs/getting-started

Other

24 stars 42 forks source link

Make android includes compatible with firebase plugin. #16

Closed kvindascr closed 6 years ago

kvindascr commented 7 years ago

The plugin has conflicts when trying to use it with firebase plugin. This improvements goes along the line of nativescript-firebase plugin and nativescript-google-maps-sdk plugin to make all google play services plugins compatible.

alexandruantonica commented 6 years ago

This will be really useful.

cesarodriguez4 commented 6 years ago

This pull request would solve a bug I'm experimenting. Consider merging @roblav96

jkasten2 commented 6 years ago

Thanks for the PR however the change from #36 will automatically resolve to the correct version based on the Gradle plugin that was added.