roblox-plus / extension

This is the source of the Roblox+ Google Chrome extension!
https://roblox.plus
47 stars 37 forks source link

Port navigation bar features -> TypeScript #75

Closed WebGL3D closed 1 year ago

WebGL3D commented 1 year ago

What :left_speech_bubble:

This review upgrade the navigation bar features, porting them to TypeScript.

As part of this, we removed the feature that pins the side navigation bar open. I did this for no good reason other than I would assume it probably makes the player experience worse, since it would just get in the way most of the time. It's closed on purpose on smaller screens, because the screen isn't big enough to show the page contents and the navigation bar at the same time.

Preview :framed_picture:

Along with this change we also updated how the DevEx rate is rendered, to be... better. It also links to the DevEx page now.

Before :nauseated_face:

chrome_e39VNyTNt6

After :money_mouth_face:

chrome_6lsVkDHCFB

Unrelated :bug:

This review also fixes a bug where the authenticated user was being improperly cached indefinitely.