search

roblox-ts / eslint-plugin-roblox-ts

7 stars 6 forks source link

Update to support ESLint 9 #46

Closed christopher-buss closed 3 months ago

christopher-buss commented 4 months ago

This updates the plugin to allow it to be used with ESLint 9, while not breaking functionality for existing users. Originally this PR was meant to support ESLint 9 directly, but after consideration, typescript-eslint currently still only officially supports ESLint 8, therefore there is no guarentees about the stability of upgrading currently. Once typescript-eslint officially supports ESLint 9, a new PR can be made to bump our dependencies then, and officially support ESLint 9.

The now deprecated @typescript-eslint/experimental-utils has been changed to @typescript-eslint/utils.

christopher-buss commented 4 months ago

I've made the releveant changes as required! Let me know if there's anything else.

christopher-buss commented 3 months ago

I've closed this so it doesn't accidentally get merged. This works for me because I'm manually defining each rule, but removing the "recommended" section in the way I have will cause the code that generates the ruleset to not work. TypeScript ESLint utils v8 exports better ways of doing this, but it's currently in beta. I'll either fix this PR up, or wait until the utils is ready and create a proper ESLint 9.0 release down the line.