search

robmarkcole / HASS-S3

Home Assistant integration for S3
Apache License 2.0
24 stars 15 forks source link

Add GitHub Actions #8

Closed KTibow closed 3 years ago

KTibow commented 3 years ago

Closes #7, see https://KTibow/ha-blueprint#readme

robmarkcole commented 3 years ago

@KTibow what is the benefit of 


  schedule:
    - cron: '0 0 * * *'
```?
KTibow commented 3 years ago

If hassfest gets upgraded, if new syntax is now required, it'll let you know even if you haven't pushed for a while.

robmarkcole commented 3 years ago

ok great, thanks!

robmarkcole commented 3 years ago

@KTibow can you advise?

image

KTibow commented 3 years ago

Yeah, just change the part where it says HACS/integration/action to HACS/action

KTibow commented 3 years ago

Do you think I should send out PRs to everyone to update it?

robmarkcole commented 3 years ago

@KTibow another error: Unexpected input(s) 'GITHUB_TOKEN', valid inputs are ['ignore', 'category', 'repository']

RE updates to everyone, sounds overkill to me, they would get the alerts already, but its your call!

KTibow commented 3 years ago

You don't need the github_token anymore. Just remove it.

robmarkcole commented 3 years ago

@KTibow not like this? https://github.com/robmarkcole/HASS-S3/actions/runs/381258568

KTibow commented 3 years ago

Add ignore: [brands] to the with stuff

robmarkcole commented 3 years ago

Another error https://github.com/robmarkcole/HASS-S3/actions/runs/381295208 Could you create a new PR to fix? Many thanks

KTibow commented 3 years ago

Really, I think that would be overkill. Just change ignore to all caps.

robmarkcole commented 3 years ago

Still failing: Exception: Integration is invalid, according to hassfest

KTibow commented 3 years ago

Some repos fail randomly. For now just remove my action and follow HACS guidelines.