Closed magicDGS closed 6 years ago
Actually, in #76 I detected that the option is not documented, although in the Wiki is. What should we do with it?
Die when anyone tries to use it and print an "OBSOLETE: Hasn't worked for a while." message?
2018-02-27 14:35 GMT+01:00 Daniel Gómez-Sánchez notifications@github.com:
Actually, in #76 https://github.com/robmaz/distmap/pull/76 I detected that the option is not documented, although in the Wiki is. What should we do with it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robmaz/distmap/issues/64#issuecomment-368875636, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad_FfIPMt8-_NdxaXlOmg03LMpT90mw3ks5tZASVgaJpZM4SPLMd .
I would do that. In addition, I would document in the help adding a short-note saying that because trimming is done while uploading, the user can trim locally if they require the trimmed unmapped reads; otherwise, the mapped files would be trimmed and can be converted to FASTQ using ReadTools or picard.
If the reads are trimmed on upload after #53, the
--only-download-trimmed-reads
won't work any longer. There are several options:.distmap
, and.tfq
after https://github.com/magicDGS/ReadTools/issues/404). Then, download can be done by just calling any of the "Reads conversion" tools to download as FASTQ or standardized SAM/BAM/CRAM..tfq
will be an easy one-liner; for legacy format, it will require a python/perl script (I think that already implemented)I am in favor of removing, but it is your decision @robmaz!