search

robmcmullen / omnivore

Hex editor and debugging emulator, sponsored by the Player/Missile Podcast
Mozilla Public License 2.0
53 stars 7 forks source link

Put label generation and destination label generation into udis_fast #122

Closed robmcmullen closed 7 years ago

robmcmullen commented 7 years ago

Searching (#111) is not scanning labels, but doing it in python would probably be too slow. It seems like label generation could be moved pretty easily to udis_fast, adding extra entries to CurrentRow like dest_label and "instruction_with_label" where the label has replaced the raw hex instruction.

robmcmullen commented 7 years ago

Labels could be stored in a fixed array of 5 chars since they are in the form "Lxxxx", and a 16 bit pointer could be used to point to them. The index of the label would be simple be the pointer value * 5

robmcmullen commented 7 years ago

I don't think this is worth it. It seems fast enough with the changes for #175