search

robmikh / displayrecorder

A utility to record displays.
MIT License
15 stars 7 forks source link

Errors don't automatically end a recording #1

Closed robmikh closed 3 years ago

robmikh commented 3 years ago

Currently an error on the encoder thread only stops that thread. The user must still press ENTER to stop the recording, after which the error will be printed.

Ideally, an error would immediately end the recording. Although a stop-gap may be to print that the error thread is ending due to an error to tell the user the recording isn't happening.

robmikh commented 3 years ago

Stop gap implemented in 610ac1c707ee4b9cbcc0aa12ec04d4c4c12819aa.

robmikh commented 3 years ago

This is good enough for now, even if I were to stop the recording, the user would still have to press ENTER.