search

robmueller / cache-fastmmap

Uses an mmap'ed file to act as a shared memory interprocess cache
http://search.cpan.org/~robm/Cache-FastMmap/
18 stars 15 forks source link

Fix race condition when creating file #16

Closed oschwald closed 3 years ago

oschwald commented 5 years ago

This fixes a race condition when creating a new file with multiple processes that could result in a SIGBUS, e.g.:

    Program terminated with signal SIGBUS, Bus error.
    0  __memset_avx2_erms () at ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:141
    1  0x00007f9b476c1bf9 in _mmc_init_page (cache=0x562e26507730, p_cur=1807) at mmap_cache.c:1077
    2  0x00007f9b476c1f2d in mmc_init (cache=0x562e26507730) at mmap_cache.c:180
    3  0x00007f9b476c0633 in XS_Cache__FastMmap_fc_init (cv=<optimized out>) at FastMmap.c:252
    4  0x0000562e1d78e718 in Perl_pp_entersub () at pp_hot.c:5232
    5  0x0000562e1d784e63 in Perl_runops_standard () at run.c:41
    6  0x0000562e1d705924 in Perl_call_sv (sv=sv@entry=0x562e1f862788, flags=flags@entry=13) at perl.c:3021
    7  0x0000562e1d70800e in Perl_call_list (oldscope=oldscope@entry=2, paramList=0x562e1f8628d8) at perl.c:5061
    8  0x0000562e1d6e8fb1 in S_process_special_blocks (floor=floor@entry=45, fullname=<optimized out>, fullname@entry=0x562e1f86d930 "BEGIN",
       cv=cv@entry=0x562e1f862788, gv=<optimized out>) at op.c:10350
    9  0x0000562e1d6ff856 in Perl_newATTRSUB_x (floor=floor@entry=45, o=<optimized out>, proto=<optimized out>, proto@entry=0x0, attrs=<optimized out>,
       attrs@entry=0x0, block=0x562e1f86d840, block@entry=0x562e1f86d8c0, o_is_gv=o_is_gv@entry=false) at op.c:10275
    10 0x0000562e1d7026d6 in Perl_utilize (aver=<optimized out>, floor=45, version=<optimized out>, idop=0x562e1f86c748, arg=<optimized out>) at op.c:7484
    11 0x0000562e1d735e1c in Perl_yyparse (gramtype=gramtype@entry=258) at perly.y:329
    12 0x0000562e1d70b83a in S_parse_body (xsinit=0x562e1d6e7230 <xs_init>, env=0x0) at perl.c:2509
    13 perl_parse (my_perl=<optimized out>, xsinit=0x562e1d6e7230 <xs_init>, argc=<optimized out>, argv=<optimized out>, env=0x0) at perl.c:1803
    14 0x0000562e1d6e7066 in main (argc=<optimized out>, argv=<optimized out>, env=<optimized out>) at perlmain.c:121

This happens as one process could create the file and be filling it with 0s while another process would memory map and try to initialize the file.

This also addresses races during the file size check.

This does not address the race during initialization of the pages. Although those should not result in segfaults, we would ideally lock the file until it was fully initialized. I avoided doing this primarily because I didn't want to deal with the win32 code.

oschwald commented 3 years ago

Closing this in favor of rebased #24.