robmueller / cache-fastmmap

Uses an mmap'ed file to act as a shared memory interprocess cache
http://search.cpan.org/~robm/Cache-FastMmap/
18 stars 15 forks source link

JSON required for tests but not declared #20

Closed szabgab closed 4 years ago

szabgab commented 4 years ago
Could not load serialization package: JSON : Can't locate JSON.pm in @INC (you may need to install the JSON module) (@INC contains: /__w/cache-fastmmap/cache-fastmmap/blib/lib /__w/cache-fastmmap/cache-fastmmap/blib/arch /usr/local/lib/perl5/site_perl/5.30.3/x86_64-linux-gnu /usr/local/lib/perl5/site_perl/5.30.3 /usr/local/lib/perl5/vendor_perl/5.30.3/x86_64-linux-gnu /usr/local/lib/perl5/vendor_perl/5.30.3 /usr/local/lib/perl5/5.30.3/x86_64-linux-gnu /usr/local/lib/perl5/5.30.3 .) at (eval 13) line 1.
# Looks like your test exited with 2 just after 2.

See full output: https://github.com/szabgab/cache-fastmmap/runs/1374034225?check_suite_focus=true

One solution would be to skip that specific test if JSON is not available.

szabgab commented 4 years ago

Same with Sereal::Encoder

The next run: https://github.com/szabgab/cache-fastmmap/runs/1374060507?check_suite_focus=true

robmueller commented 4 years ago

Have fixed in 1.51 and released to cpan along with your other PR's. Thanks

szabgab commented 4 years ago

Nice.