robn / p5-etcd

Perl client library for etcd
3 stars 3 forks source link

should Etcd::Node::nodes default to []? #4

Open querry43 opened 10 years ago

querry43 commented 10 years ago

It would be a bit easier to navigate the tree if Etcd::Node::nodes defaulted to an empty arrayref. If you agree, I'll put in a pull request.

robn commented 10 years ago

Yes, agreed.

Do you want direct commit access? You're doing good work and there's no point me slowing you down :)

querry43 commented 10 years ago

I could take or leave direct commit access. If I had it, then I would probably have to get code reviews from my co-workers here and that might take longer.

robn commented 10 years ago

Sure, I understand. Lets leave it this way for now then.