search

robnyman / domassistant

Automatically exported from code.google.com/p/domassistant
1 stars 0 forks source link

isIE5 variable contains the wrong value #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The isIE5 variable in DOMAssistant.js actually contains whether or not we're on 
Trident 5, (I think). From looking at where isIE5 it seems that we're more 
interested in knowing if document.all works as expected. 

This patch contains a fix where we test to see if document.getElementsByTagName 
works right, and if so then we set a variable docAll to false, and I've updated 
DOMAssistant.getTags() to use the new docAll variable.

Note: This patch also contains a fix for the next issue I'm going to enter, 
which will be #33.

Original issue reported on code.google.com by johnbea...@gmail.com on 17 Nov 2011 at 3:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Won't change as it broke more stuffs than it fixes.

Original comment by chengh...@gmail.com on 18 Nov 2011 at 8:38