search

robocin / ssl-core

MIT License
10 stars 0 forks source link

[Bug]: app-shell navigation #92

Open mateusriff opened 3 months ago

mateusriff commented 3 months ago

Describe the issue.

I was testing the app-shell and came across a problem when I tried to navigate back with my browser's "go back" button. window.location.href changes, but the rendered content of the page does not. An Uncaught TypeError is thrown at router.ts whenever this happens.

Describe the needed steps to reproduce the problem.

  1. Use yarn run dev to run the app-shell.
  2. Access the development server.
  3. At the home page, click on any one of the navbar items to navigate to another page.
  4. Try to navigate back to the home page using your browser's "go back" button.

You will notice window.location.href changes, but the rendered content does not. To be clear, this does not only happen when you go from the home page to another and try to navigate back. It happens whenever you try to navigate back in-between any of the pages.

Describe the used docker image name and tag.

No response

Provide additional context.

I have recorded a video showing the navigation bug. You can check it out here.

It is also worth pointing out that an Uncaught TypeError is thrown at router.ts:121:18 when this bug happens:

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at router.ts:121:18
(anonymous) @ router.ts:121
mateusriff commented 2 months ago

Further testing revealed this navigation problem seems to be inconsistent. It does not always happen. Sometimes, the navigation works just fine. I couldn't figure out why yet.