search

robocode-dev / tank-royale

Git repository for Robocode Tank Royale
Apache License 2.0
143 stars 29 forks source link

Server websocket over wss #106

Open SirStone opened 2 months ago

SirStone commented 2 months ago

I've developed a web app called RTR-OBSERVER that can be installed as a Progressive Web App (PWA) and used offline on smartphones.

When running it locally via HTTP, it works well. However, for real-world deployment, HTTPS is required to make the PWA work. This also means that the WebSocket connections need to use a secure connection (wss://).

@flemming-n-larsen, have you ever considered this issue?

flemming-n-larsen commented 2 months ago

Nice work with the RTR-OBSERVER :+1:😊

Regarding WSS, I have considered this, but not prioritized it yet. 🙂 But I will try to set up a server to use WSS and see how it goes. It should be easy to handle on the client side, but will require more work on the server side, e.g. setting up a certificate + UI and documentation stuff.

flemming-n-larsen commented 2 months ago

@SirStone I have had a look into this, and it should not be a big problem to support WSS. 😊

But I will fix #96 first, so the configuration and setup is better prepared for this feature when selecting the server.

SirStone commented 2 months ago

@flemming-n-larsen no rush, I'm just glad you considered my request for implementation.

flemming-n-larsen commented 1 month ago

@SirStone With release 0.26.0, remote servers are now supported. Lots of work has been put into this release (mostly on the GUI side) to support both remote and local servers, and it is a much better foundation for incorporation WSS in a coming release.

SirStone commented 1 month ago

Great! Now I'm curious about the changes on the GUI :)

Il Dom 20 Ott 2024, 11:38 Flemming N. Larsen @.***> ha scritto:

@SirStone https://github.com/SirStone With release 0.26.0 https://github.com/robocode-dev/tank-royale/releases/tag/v0.26.0, remote servers are now supported. Lots of work has been put into this release (mostly on the GUI side) to support both remote and local servers, and it is a much better foundation for incorporation WSS in a coming release.

— Reply to this email directly, view it on GitHub https://github.com/robocode-dev/tank-royale/issues/106#issuecomment-2424780910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7Z3HN3PRMD2Y774ZIATTZ4N2ZLAVCNFSM6AAAAABN5L6EZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRUG44DAOJRGA . You are receiving this because you were mentioned.Message ID: @.***>