Starting battle on LAN Websocket address

[electricSoda]

The bug When you start a Robocode Tank Royale server from the GUI on any LAN Websocket address, boot up bots to connect to the server through the command line (e.g. java -cp ../lib/* AvoidWall.java), and then try and start up a match between these bots through the GUI, the match doesn't start.

To Reproduce

• Go to the server.properties file and add your computer's LAN address converted to a websocket address (e.g. ws://192.168.1.20:3000) to the server-urls property

• Select the the IP address from Server > Select Server from the GUI

• Start up a server on this new websocket address through the GUI (Server > Start Server)

• On a separate computer (or on the same computer), change the SERVER_URL environment variable (by doing set SERVER_URL=<url>) to the same websocket address you did in the server.properties file

• Also make sure to configure the secret for the bots by doing set SERVER_SECRET=<secret>; you can find the bots-secrets in the server.properties file

• Then go in command prompt or terminal and then boot up a bot e.g. java -cp ../lib/* Corners.java

• It should show that it's connected on the battle menu thingy on the GUI (in the Joined Bots (local/remote))

• Add that remote bot for battle

• Boot up another bot from a local directory through the GUI (not from command line)

• Click start battle

• You will see that the pop up for selecting bots disappears like it's going to start a match, but then nothing shows up on the main screen (the battle interface doesn't show up)

Desktop (please complete the following information):

• Windows 10

Java info:

• Java 16.0.2 (yeah I need to update Java lol)
  • Vendor: Oracle

[flemming-n-larsen]

@electricSoda Thank you for reporting this as a bug and providing really good information for how to reproduce the issue you see. 😊👌

I will have a look into this issue.

[flemming-n-larsen]

I reproduced the problem :+1: So I will figure out how to fix that

@electricSoda When you start a local server, it will start up at localhost:, not the address(es) specified with the 'Select Server' dialog. This dialog is mainly meant for which server the GUI will connect to, which could be an external server or local server. It might even run from a Docker container or Linux shell within Windows.

That said, I believe the local IP address and localhost must be resolved equally, meaning that the GUI should be able to connect to the server. So it is still a bug, and a dialog should show up for sure.

[electricSoda]

Sounds good 👍