search

robocorp / rcc

Repeatable, movable and isolated Python environments for your automation. 🚀
https://robocorp.com/docs/
Apache License 2.0
461 stars 97 forks source link

Remove dependency from English language on Windows by using SID instead of group name #54

Closed simonmeggle closed 9 months ago

simonmeggle commented 9 months ago

I am experiencing problems with RCC on a german Windows system. The command 

rcc holotree shared --enable

returns with an error:

image

This is because the localized Windows versions have other names for the group "Users" (in Germany: "Benutzer").

A way to solve such localization issues is to avoid names of users and groups and use their SID instead. (https://learn.microsoft.com/en-US/windows-server/identity/ad-ds/manage/understand-security-identifiers)

Therefore, I request to change the command in cmd/command_windows.go to 

icacls C:\ProgramData\robocorp /grant "*S-1-5-32-545:(OI)(CI)M" /T /Q

which has exactly the same effect.

Thanks and regards :wave: Simon

kariharju commented 9 months ago

Great issue @simonmeggle!

Back when we made this either the article did not have those documented or I just could not find them. With this documentation coming from Microsoft I feel confident jumping on these.

simonmeggle commented 9 months ago

I have a Robotmk field test this afternoon with a customer who has a German Windows installed. For this we compiled RCC with this wellknown-SID patch. I will report if everything worked!

simonmeggle commented 9 months ago

@kariharju The patched version of RCC with the SID worked as expected :+1: We will submit a PR :-)

vjmp commented 9 months ago

PR taken manually. This is in rcc v17.15.0. Added needed changelog and version info.