search

robocup-logistics / gazebo-rcll

Gazebo Models, Plugins, and World Files for the RoboCup Logistics League
GNU General Public License v2.0
17 stars 12 forks source link

plugins: implement Gazebo 8 API changes #7

Closed vmatare closed 7 years ago

vmatare commented 7 years ago

Lots of functions & classes are deprecated in Gazebo 8. This commit adds a bunch of wrapper macros that redirect to the appropriate calls & types depending on whether Gazebo V <= 5 or 5 < V < 8 or V >= 8. Yes, I know this is an outrageous preprocessor hack, but trust me, you do not want to see the corresponding amount of #if's and #else's in the source files.

vmatare commented 7 years ago

I have tested this with Gazebo 8 only. Since this commit introduces extensive changes and adds lots of redirecting macros, it should be tested at least against Gazebo 7.

ValentinVERGEZ commented 7 years ago

Hi @vmatare,

I can test with Gazebo 5, but only later in the month. As far as our team is concerned, you already can merge your work as is. If some modification are needed for Gazebo 5, I will open a new PR with the corresponding fixes.

Concerning the rulebook, do you know when the 2017 version will be released or do you already have a draft version to share ?

Thanks, Valentin (Pyro Team)

zwilling commented 7 years ago

Works well with Gazebo 5.1 Btw: If you update the llsf.world according to the 2017 rules, we have to wait until the Lab course simulation competition is over before merging that.