robocupjunioraustralia / RCJA_Registration_System

A custom registration system for RoboCup Junior Australia built in Django.
https://enter.robocupjunior.org.au
4 stars 0 forks source link

Fix bug causing working pricing to be displayed incorrectly where there is a difference between teacher and student pricing #651

Closed evanbailey closed 6 months ago

evanbailey commented 6 months ago

It was found that the workshop pricing being shown was always the intitial 'default' amount entered, not the actual teacher and student price set. This was only noticable if the teacher and student pricing was later change from the amount initially set, hence why it has gone unnoticed for quite some years.

This has now been fixed. It also has been fixed in the code that lives on the website to display pricing.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.09%. Comparing base (d86dd96) to head (4ca38af).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #651 +/- ## ======================================= Coverage 93.09% 93.09% ======================================= Files 159 159 Lines 3970 3970 Branches 469 469 ======================================= Hits 3696 3696 Misses 228 228 Partials 46 46 ``` | [Flag](https://app.codecov.io/gh/robocupjunioraustralia/RCJA_Registration_System/pull/651/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=robocupjunioraustralia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/robocupjunioraustralia/RCJA_Registration_System/pull/651/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=robocupjunioraustralia) | `93.09% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=robocupjunioraustralia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.