Minor bug in deployment side image_transform

robodhruv / drive-any-robot

Official code and checkpoint release for "GNM: A General Navigation Model to Drive Any Robot".

MIT License

264 stars 42 forks source link

Minor bug in deployment side image_transform #16

Closed lasuomela closed 1 year ago

lasuomela commented 1 year ago

Hi,

Nice work! I've been testing the method, and ran into a bug in the deployment version of the image_transform function (https://github.com/PrieureDeSion/drive-any-robot/blob/main/deployment/src/utils.py#L89).

The order of image_size is flipped twice (lines 99, 103), resulting in the image_size being given to resize as WxH instead of HxW. In my experience this was affecting collision avoidance performance to some extent.

Br, Lauri

ajaysridhar0 commented 1 year ago

Hi Lauri,

Thank you for catching this bug! We just fixed it, but let me know if you find any other issues.

Best, Ajay