search

robodhruv / visualnav-transformer

Official code and checkpoint release for mobile robot foundation models: GNM, ViNT, and NoMaD.
http://general-navigation-models.github.io
MIT License
425 stars 56 forks source link

process_data #9

Closed Qiang-Yun closed 5 months ago

Qiang-Yun commented 7 months ago

Hi, Is it more reasonable to update 'currtime' within the 'if' statement here? Update 'currtime' after storing synchronized data. Thanks~

https://github.com/robodhruv/visualnav-transformer/blob/bd3dbda18e0ade852bdedda98866bdb3e599ba72/train/vint_train/process_data/process_data_utils.py#L179C4-L179C4

ajaysridhar0 commented 5 months ago

Hi @Qiang-Yun,

Thanks for catching this! I fixed it here: https://github.com/robodhruv/visualnav-transformer/commit/5b4c8165d10f0c9246e25cb530a026f8924e61cd

--Ajay

Qiang-Yun commented 5 months ago

收到了O(∩_∩)O~