roboflow / inference

A fast, easy-to-use, production-ready inference server for computer vision supporting deployment of many popular model architectures and fine-tuned models.
https://inference.roboflow.com
Other
1.3k stars 116 forks source link

Pass Inputs to Outputs when Wired #412

Closed yeldarby closed 4 months ago

yeldarby commented 4 months ago

Description

This fixes a bug where if you add one of the input parameters as an output the default value doesn't make its way through. This is useful when wanting to display input values (like a hard-codes string) in your rendering code.

Type of change

How has this change been tested, please provide a testcase or example of how you tested the change?

We implemented this to use in @josephofiowa's demo last week & have now tested it several times end to end with new workflows (installing inference from this branch).

On top of that, we want to create 0.11.1 release, so:

Any specific deployment considerations

No

Docs

PawelPeczek-Roboflow commented 4 months ago

We are impacted by new release of setuptools that happened yesterday. https://pypi.org/project/setuptools/#history

Root cause:

Impact:

PawelPeczek-Roboflow commented 4 months ago

We should probably distribute note of the following (or similar) content to people using inference

Using setuptools in version 70.0.0 and above breaks usage of Clip and YoloWorld models. That impacts historical version of inference package installed in python environments with newest setuptools.
We will release change pinning setuptools version into compatible one soon, working on the solution for that constraint not to be needed.

As a solution for now, we recommend enforcing setuptools<70.0.0 in all environments using inference:
`pip install setuptools>=65.5.1,<70.0.0`
PawelPeczek-Roboflow commented 4 months ago

@yeldarby I will make a release from that branch once u confirm u are fine with this

yeldarby commented 4 months ago

Yep looks good (I think you have to be the one to actually ✅ because I’m the one who submitted the PR though).

PawelPeczek-Roboflow commented 4 months ago

ok, merging and I will release as 0.11.1 later afternoon

PawelPeczek-Roboflow commented 4 months ago

Preparing release from this branch: JETSON 4.5: image builds JETSON 4.6.1 tests 🟢 https://github.com/roboflow/inference/actions/runs/9203845879 JETSON 5.1.1 - local build 🟢 NVIDIA GPU tests 🟢 https://github.com/roboflow/inference/actions/runs/9203849682