search

roboflow / inference

A fast, easy-to-use, production-ready inference server for computer vision supporting deployment of many popular model architectures and fine-tuned models.
https://inference.roboflow.com
Other
1.3k stars 116 forks source link

Abstract ImageInputField and RoboflowModelField + Copy Changes #445

Closed yeldarby closed 4 months ago

yeldarby commented 4 months ago

Description

Updates the display name for Roboflow model fields from Model Id to Model, tweaks description copy, and abstracts these common Fields into references so they can all be changed together in the future vs having to happen in many different files (or, worse, diverge from each other).

Fix https://github.com/roboflow/roboflow/issues/3515

Type of change

How has this change been tested, please provide a testcase or example of how you tested the change?

Ran unit tests

Any specific deployment considerations

No

Docs

yeldarby commented 4 months ago

I was running the wrong unit tests locally earlier. Looks like the workflows ones are failing with

inference.core.workflows.errors.BlockInterfaceError: Attempted to retrieve property images from manifest of step model_1 based od manifest schema, but property is not defined for object instance. That may be due to aliasing of manifest property name in pydantic class, which is not allowed.

I'm not really sure why though when it worked when these Fields were defined inline.