roboflow / inference

A fast, easy-to-use, production-ready inference server for computer vision supporting deployment of many popular model architectures and fine-tuned models.
https://inference.roboflow.com
Other
1.3k stars 116 forks source link

Added Inference IDs to Sources when Uploaded via the Dataset Upload Block #571

Closed chandlersupple closed 1 month ago

chandlersupple commented 1 month ago

Description

When an image is uploaded through Active Learning, Model Monitoring allows users to view the image in its "Recent Inferences" table. This currently works with Active Learning, however, it does not work with the new "Roboflow Dataset Upload" block in Workflows.

Modified the Dataset Upload block to provide the inference_id to register_image_at_roboflow() (As is currently being done in Active Learning).

Type of change

How has this change been tested, please provide a testcase or example of how you tested the change?

Any specific deployment considerations

N/A

Docs

N/A

PawelPeczek-Roboflow commented 1 month ago

Updated my branch with your changes fixing issues I spotted and adding tests: https://github.com/roboflow/inference/pull/565/commits/0962acd9b84b4d016a53f86ccc77c41852569dfe

@chandlersupple please verify + suggestion for next contribution - if you change behaviour of code such that you add / remove parameter and this is somewhat important change you shall expect some test to fail - if that's not the case and you care about change you should modify existing tests / add new test to ensure coverage

PawelPeczek-Roboflow commented 1 month ago

to be closed soon