roboflow / multimodal-maestro

Effective prompting for Large Multimodal Models like GPT-4 Vision, LLaVA or CogVLM. 🔥
https://maestro.roboflow.com
MIT License
1.02k stars 73 forks source link

Bug at generate marks #14

Open jyC23333 opened 9 months ago

jyC23333 commented 9 months ago

Search before asking

Bug

Traceback (most recent call last): File "/data/megvii/projects/Qwen-VL/scripts/test_maestro.py", line 7, in marks = generator.generate(image=image) File "/data/Anaconda/anaconda3/envs/autogpt/lib/python3.10/site-packages/maestro/markers/sam.py", line 44, in generate return masks_to_marks(masks=masks) File "/data/Anaconda/anaconda3/envs/autogpt/lib/python3.10/site-packages/maestro/postprocessing/mask.py", line 187, in masks_to_marks return sv.Detections( File "", line 8, in init File "/data/Anaconda/anaconda3/envs/autogpt/lib/python3.10/site-packages/supervision/detection/core.py", line 89, in __post_init__ _validate_mask(mask=self.mask, n=n) File "/data/Anaconda/anaconda3/envs/autogpt/lib/python3.10/site-packages/supervision/detection/core.py", line 29, in _validate_mask raise ValueError("mask must be 3d np.ndarray with (n, H, W) shape") ValueError: mask must be 3d np.ndarray with (n, H, W) shape

Environment

Ubuntu 20.04 python=3.10.10

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

SkalskiP commented 9 months ago

Hi @jyC23333! 👋🏻 Could you share the code you run and image you used? Basically something more so I can understand better what happens?

jyC23333 commented 9 months ago

Hi,@SkalskiP ,my code shows below:

import cv2
import maestro

image = cv2.imread('./鲫鱼.png')

generator = maestro.SegmentAnythingMarkGenerator(device='cuda')
marks = generator.generate(image=image)
marks = maestro.refine_marks(marks=marks)

mark_visualizer = maestro.MarkVisualizer()
marked_image = mark_visualizer.visualize(image=image, marks=marks)

something wrong at this line:

marks = generator.generate(image=image)

original image: 鲫鱼

SkalskiP commented 9 months ago

Thanks @jyC23333. I'll get back to you!

SkalskiP commented 9 months ago

Hi @jyC23333 👋🏻 I just tested using the latest version of maestro, and everything works.

Take a look at this Colab.

Make sure to use the 0.1.1rc1 version. Please let me know if that helped.

jyC23333 commented 8 months ago

@SkalskiP Hi,the bug still exists with the latest version. image

This is my cuda info: image

And I'm using torch 2.1.0: image

SkalskiP commented 8 months ago

Hi @jyC23333, the bug doesn't exist in the Colab I sent you, so it must be environment-dependent. What version of transformers and supervision you have?

jyC23333 commented 8 months ago

@SkalskiP Hi,the dependent info is: image image

hvaria commented 5 months ago

To address the bug, add debug logs around self.pipeline in generate to check data shapes and integrity. Monitor GPU usage to ensure no memory overflow—silent issues may not trigger clear error messages

SkalskiP commented 5 months ago

I'm very sorry, but I'm extremely busy. I'll try to look at it as soon as possible.