roboflow / notebooks

Examples and tutorials on using SOTA computer vision models and techniques. Learn everything from old-school ResNet, through YOLO and object-detection transformers like DETR, to the latest models like Grounding DINO and SAM.
https://roboflow.com/models
5.09k stars 788 forks source link

issue#41 #42

Closed SriPrarabdha closed 1 year ago

SriPrarabdha commented 1 year ago

Description

This code solves a bug present in YOLO v8 Object Detection Notebook (issue #41 ).The code just creates a new folder datasets and moves our football dataset into it . Further it changes the path of our data in the script

Type of change

Please delete options that are not relevant.

How has this change been tested, please provide a testcase or example of how you tested the change?

I have tested this code on both Google Colab and Kaggle notebooks and it works nicely

SkalskiP commented 1 year ago

Hi @SriPrarabdha 👋🏻! Thank you very much for the PR! Did you investigate what is the reason for that behavior? I was running that notebook multiple times last week and it was working smoothly.

SkalskiP commented 1 year ago

Hi @SriPrarabdha 👋🏻! I just found a more elegant solution to solve the problem. Also, it turned out that it forced changes not only in object detection but also in instance segmentation and image classification YOLOv8 notebooks. For those reasons, we will not merge this PR.

However, I would still like to thank you for your contribution. Without this PR we wouldn't be able to fix the problem as quickly. 🙏🏻 Thank you very much!