search

roboflow / roboflow-100-benchmark

Code for replicating Roboflow 100 benchmark results and programmatically downloading benchmark datasets
https://www.rf100.org
MIT License
248 stars 24 forks source link

Download Script Stuck #31

Closed yeldarby closed 1 year ago

yeldarby commented 1 year ago

Propagating this issue from Hacker News:

The download script at https://github.com/roboflow/roboflow-100-benchmark/blob/main... got stuck at "Generating version still in progress. Progress: 98.75%". When restarting the script, it got stuck at "Generating version still in progress. Progress: 148.15%".

I think this likely is related to this PR merged a few hours ago. One of the datasets looks to have progress marked as greater than 100% which is causing the script to think it’s not completed yet & wait indefinitely.

yeldarby commented 1 year ago

I pushed an update to our backend API to fix this issue & verified the download script works again.

The underlying problem was that we added error checking to our API to ensure that all images in a version had finished being generated before allowing the dataset to be exported and archived into a zip file.

This error checking was too strict and didn't handle the edge case where there were some corrupted images that failed to generate properly, which made our pip package wait indefinitely for the progress to reach 100% (which would never happen due to the corrupted images).

I added a timeout to prevent failed images from preventing exporting the rest of the dataset.