search

roboflow / roboflow-python

The official Roboflow Python package. Manage your datasets, models, and deployments. Roboflow has everything you need to build a computer vision application.
https://docs.roboflow.com/python
Apache License 2.0
280 stars 72 forks source link

bumped chardet to 5.2.0 #230

Closed telamonian closed 1 month ago

telamonian commented 6 months ago

Description

Fixes #195.

Alternative PR to #197. Unlike that older PR, this one bumps chardet all the way up to the current version 5.2.0. This is now possible since this project has moved to python>=3.8 since the older PR was first made.

Type of change

Please delete options that are not relevant.

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested locally, seems fine. Will wait for unittests to pass on github before final judgement.

Any specific deployment considerations

NA

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: iurisilvio
:x: telamonian
You have signed the CLA already but the status is still pending? Let us recheck it.

capjamesg commented 2 months ago

@telamonian Can you accept the CLA so we can merge this PR?

capjamesg commented 1 month ago

This PR has been replaced with https://github.com/roboflow/roboflow-python/pull/303 as we are unable to merge PRs where all contributors have not signed the CLA.