roboflow / roboflow-python

The official Roboflow Python package. Manage your datasets, models, and deployments. Roboflow has everything you need to build a computer vision application.

https://docs.roboflow.com/python

Apache License 2.0

271 stars 70 forks source link

Fix all obvious bugs found by mypy #265

Closed iurisilvio closed 2 months ago

iurisilvio commented 2 months ago

Description

Mypy found a lot of issues, but many are just typing inconsistencies.

This PR focus on real obvious bugs.

I'm sure other errors cause minor bugs too, but later I'll take on these improvements.

Using demo keys would break the Version(...) init because of missing public kwarg.
Exceptions being raised as strings are not supported anymore (since Python 3?).
clip_compare function was broken because of a missing arg.
urljoin accept a third arg allow_fragments. We're not passing api_key in these requests, not sure if they're working.
Video .poll_until_results() was broken because of wrong call to .poll_for_results().

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Pass on CI.

iurisilvio commented 2 months ago

@capjamesg can you take a look on video inference here? Based on mypy results, VideoInference looks broken, sending requests without api key and calling wrong methods. 😅