search

roboflow / roboflow-python

The official Roboflow Python package. Manage your datasets, models, and deployments. Roboflow has everything you need to build a computer vision application.
https://docs.roboflow.com/python
Apache License 2.0
272 stars 71 forks source link

Fix types in version init #279

Closed iurisilvio closed 1 month ago

iurisilvio commented 1 month ago

Description

Fix errors found after mypy merge.

roboflow/core/version.py:110: error: Unsupported operand types for in ("str" and "Response")  [operator]
roboflow/core/version.py:110: error: Value of type "Response" is not indexable  [index]

It was a small bug that would be triggered only when our API failed.

Minor regression from https://github.com/roboflow/roboflow-python/pull/276.

Type of change

Please delete options that are not relevant.

How has this change been tested, please provide a testcase or example of how you tested the change?

CI pass.

iurisilvio commented 1 month ago

@stellasphere tagging you for review because it is a recent change you worked on.

My mypy branch was outdated and now main branch is broken. 🤦🏻‍♂️